[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

confessions :( and a patch for lm93 on non-C99 compilers :)



Hi,

the 2.8.8 rpms are a fake, I had been packaging 2.8.6 instead ... :(

Thanks to Rolf Müller for finding this bug. New packages with real
2.8.8 will soon be uploaded. Sorry for the mess. ... :(

Building (the real) 2.8.8 on RH7.3 uncovered a small C99-ism, patch
against CVS is attached.
-- 
Axel.Thimm at ATrpms.net
Index: kernel/chips/lm93.c
===================================================================
RCS file: /home/cvs/lm_sensors2/kernel/chips/lm93.c,v
retrieving revision 1.13
diff -u -d -r1.13 lm93.c
--- kernel/chips/lm93.c	22 Oct 2004 04:26:45 -0000	1.13
+++ kernel/chips/lm93.c	23 Oct 2004 09:14:42 -0000
@@ -1707,10 +1707,12 @@
 	if (operation == SENSORS_PROC_REAL_INFO)
 		*nrels_mag = 0;
 	else if (operation == SENSORS_PROC_REAL_READ) {
+		int mapping;
+
 		lm93_update_client(client);
 
 		/* extract the relevant mapping */
-		int mapping = (data->sf_tach_to_pwm >> (nr * 2)) & 0x03;
+		mapping = (data->sf_tach_to_pwm >> (nr * 2)) & 0x03;
 
 		/* if there's a mapping and it's enabled */
 		if (mapping && ((data->sfc2 >> nr) & 0x01))

Attachment: pgpVuiLNVHcDH.pgp
Description: PGP signature